Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry sign in when Grafana restarts #59

Open
phillebaba opened this issue Jul 8, 2021 · 4 comments
Open

Retry sign in when Grafana restarts #59

phillebaba opened this issue Jul 8, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request no stalebot exempt from stale bot

Comments

@phillebaba
Copy link

I have been seeing issues when running a single Grafana instance and signing in with basic auth. Signing in will work fine, but when the instance is restarted grafana-kiosk will be kicked back to the sign in page, but it will not try to sign in. The solution right now is to restart grafana-kiosk, but I feel like there may be a simpler solution to this problem.

@briangann briangann added the enhancement New feature or request label Jul 9, 2021
@briangann
Copy link
Collaborator

This is a general problem, if the instance restarts and you lose your credentials (session token expires), the browser is sent back to the login screen.

Right now it's just infinitely waiting for the process to be killed.

The kiosk could inspect page loads and try to detect the login page.

There's the other issue of the session token expiring (and the grafana instance hasn't restarted), which also sends you back to the login page. Setting a long timeout on the expiration can alleviate it, but it's not a great fix.

Detecting the login would solve both problems, but may cause some undesirable load on the kiosk. I'll have to see what the impact it will cause, and maybe just add a new flag to enable it.

@briangann
Copy link
Collaborator

made progress on this and also discovered a bug that will help with performance, will get a new release out that addresses cpu utilization, then add the re-login code.

@briangann briangann self-assigned this Sep 13, 2021
@phillebaba
Copy link
Author

@briangann have you been able to make some progress on this? It's not really a super critical issue as we do not experience this too often but it happens at times.

@NissesSenap
Copy link

ping @briangann any update?

@github-actions github-actions bot added the stale label Mar 7, 2023
@briangann briangann added no stalebot exempt from stale bot and removed stale labels Mar 7, 2023
@briangann briangann added this to To do in grafana-kiosk Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no stalebot exempt from stale bot
Projects
grafana-kiosk
  
To do
Development

No branches or pull requests

3 participants