Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing Documentation for Playlists #71

Closed
kashalls opened this issue Apr 7, 2022 · 2 comments
Closed

Confusing Documentation for Playlists #71

kashalls opened this issue Apr 7, 2022 · 2 comments

Comments

@kashalls
Copy link

kashalls commented Apr 7, 2022

When exploring documentation for using a configuration file, the README states that the config can use playlists as a boolean. It is also shown that in the usage flags, its is declared as -playlists However when inspecting the config-example it is shown that it is playlist,

https://github.com/grafana/grafana-kiosk/blob/main/scripts/grafana-kiosk.service#L11 also shows that it is used as -playlist

I am using my install with the config.yaml and having a bit of a hard time trying to get this to work as I can't get the playlist to play automagically (which may be a me issue, but I was confused about this).

Are both supported, or only one of the two?

@HerrSubset
Copy link

HerrSubset commented Apr 12, 2022

I was running into the same issue. I had playlists: true configured in my yaml config file. When checking the logs of grafana-kiosk, it would always report

grafana-kiosk[65852]: 2022/04/12 11:26:15 IsPlayList: false

Changing the config to playlist: true fixed it:

grafana-kiosk[67769]: 2022/04/12 11:29:20 IsPlayList: true

I'd be happy do make a MR to update the docs, if someone could confirm that the -playlists flag is indeed unsupported.

EDIT: this is with v1.0.4

@HerrSubset
Copy link

Seems related to #46 .

@kashalls kashalls closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants