Replicas missing in deepcopy

[AdheipSingh]

Replicas have not been added in deepcopy. In current master annotations, labels are available options in the the deployment spec.

func (in *GrafanaDeployment) DeepCopyInto(out *GrafanaDeployment) {
	*out = *in
	if in.Annotations != nil {
		in, out := &in.Annotations, &out.Annotations
		*out = make(map[string]string, len(*in))
		for key, val := range *in {
			(*out)[key] = val
		}
	}
	if in.Labels != nil {
		in, out := &in.Labels, &out.Labels
		*out = make(map[string]string, len(*in))
		for key, val := range *in {
			(*out)[key] = val
		}
	}
	return
}

I can add the replica deep copy in this PR #106

[pb82]

@AdheipSingh I ran the automatic code generation against master (operator-sdk generate k8s) and it doesn't look like anything is missing. Since the deployment spec is added as a pointer in the grafana type spec, I don't think we need a layer of deepcopy for it.

Are you seeing any issues with this on master?

[AdheipSingh]

@pb82 yes i see that, the only thing which concerned me is that replicas were not included in the deepcopy objects whereas annotations and labels were rightly present.

I ran the same command but strange it does'nt genereate deepcopy for replicas.

Don't you think replicas should also be added in this, as the deployment spec also includes the replica paramenter. Maybe i am missing on some thing.

func (in *GrafanaDeployment) DeepCopyInto(out *GrafanaDeployment) {
	*out = *in
	if in.Replicas != nil {
		in, out := &in.Replicas, &out.Replicas
		*out = new(int32)
		**out = **in
	}
	if in.Annotations != nil {
		in, out := &in.Annotations, &out.Annotations
		*out = make(map[string]string, len(*in))
		for key, val := range *in {
			(*out)[key] = val
		}
	}
	if in.Labels != nil {
		in, out := &in.Labels, &out.Labels
		*out = make(map[string]string, len(*in))
		for key, val := range *in {
			(*out)[key] = val
		}
	}
	return
}

[pb82]

@AdheipSingh No, i don't think we should manually add anything to the auto generated code. Closing this issue as i don't think there's a problem with the auto generated code.