Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request/Limits #112

Closed
AdheipSingh opened this issue Jan 3, 2020 · 2 comments
Closed

Request/Limits #112

AdheipSingh opened this issue Jan 3, 2020 · 2 comments

Comments

@AdheipSingh
Copy link
Contributor

AdheipSingh commented Jan 3, 2020

I see the quota allocation is kept as constant.
As an operator user i should be able to define these in kind: Grafana . In my deployment spec, any specific reason for keeping these as constants ??
Each user can have its own quota/limits preferences

const (
	MemoryRequest = "256Mi"
	CpuRequest    = "100m"
	MemoryLimit   = "1024Mi"
	CpuLimit      = "500m"
)
@nobody4t
Copy link
Contributor

nobody4t commented Jan 3, 2020

@AdheipSingh this is the default value for the resource. These values could be overridden from CR.
You can have a look at the grafana_types.go.

@AdheipSingh
Copy link
Contributor Author

@dongwangdw Oh i see that now, yep in that case its fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants