Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tyop/stray descripton (instead of description) field in the openapi crd spec #114

Closed
bearnard opened this issue Jan 7, 2020 · 3 comments

Comments

@bearnard
Copy link

bearnard commented Jan 7, 2020

https://github.com/integr8ly/grafana-operator/blob/master/deploy/crds/Grafana.yaml#L90

This is causing synchronisation issues with gitops flows.
When the crd is applied, Kubernetes ignores/removes the field and thus the git source of truth is alway out of sync.

@pb82
Copy link
Collaborator

pb82 commented Jan 7, 2020

@bearnard good spot, thanks!

@bearnard
Copy link
Author

bearnard commented Jan 7, 2020

Thanks @jerith for the eagle eye.

@pb82
Copy link
Collaborator

pb82 commented Jan 7, 2020

fixed on master now. Btw. there's a typo in the PR title 😉

@pb82 pb82 closed this as completed Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants