Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Unable to install multiple releases of the grafana-operator via ArgoCD #1323

Closed
alita1991 opened this issue Nov 28, 2023 · 8 comments · Fixed by #1329
Closed

[Bug] Unable to install multiple releases of the grafana-operator via ArgoCD #1323

alita1991 opened this issue Nov 28, 2023 · 8 comments · Fixed by #1329
Labels
question Further information is requested

Comments

@alita1991
Copy link

alita1991 commented Nov 28, 2023

Describe the bug

Currently, the Grafana-Operator's ClusterRole and ClusterRoleBinding are hardcoded, limiting users to installing a single release for testing purposes. Proposing to make these configurations dynamic to enable concurrent installations of multiple releases, fostering a more flexible testing environment via ArgoCD.

Version
Helm Chart v5.4.1

To Reproduce
Steps to reproduce the behavior:

  1. Install helm chart in namespace A via ArgoCD
  2. Install helm chart in namespace B via ArgoCD
  3. Applications never complete the reconciliation.

Expected behavior
Install chart multiple times without sync issues

Suspect component/Location where the bug might be occurring
The name for the ClusterRole and ClusterRoleBinding are hardcoded

@alita1991 alita1991 added bug Something isn't working needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 28, 2023
@weisdd
Copy link
Collaborator

weisdd commented Nov 28, 2023

Could you, please, describe your use-case? - Why would you want to install multiple copies of the operator when running in a cluster-wide mode?
I guess you're simply looking for "namespaceScope: true" option in the chart.

@alita1991
Copy link
Author

I'm using the grafana-operator as part of an umbrella chart and I test it via ArgoCD by deploying the umbrella in a different namespace. Right now, if I deploy the chart like it is, I receive a resource conflict and ArgoCD fails to sync.

@NissesSenap
Copy link
Collaborator

NissesSenap commented Dec 5, 2023

@alita1991 Is there any reason why you can't run it in namespaceScope: true?
The current way you are installing it, is cluster scoped, so that is why the config is as it is.

@pb82 pb82 added question Further information is requested and removed bug Something isn't working needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 5, 2023
@alita1991
Copy link
Author

I can test like this for a while, the only issue is that it will ignore the resources that are created in a different namespace. Is there a reason for having a hardcoded name, like operator is doing any kind of validation base on that name or something?

@NissesSenap
Copy link
Collaborator

Yes, this is how namespace specific operators work. Would be a bit strange otherwise.

No there is no reason like that, but changing can create issues and we don't want to do it unless there is a good reason to do it. And right now you haven't explained why we would change anything.

Right now it sounds like you don't understand how the operator works and you are trying to do some strange workaround that we don't understand.

This is not too be mean or anything, we try to accommodate all our users. But we have thousands of deployments of the operator and changing cluster rbac rules can create issues.

@weisdd
Copy link
Collaborator

weisdd commented Dec 12, 2023

#1329 will allow you to overwrite ClusterRole/ClusterRoleBinding names through fullnameOverride or nameOverride.

Copy link

This issue hasn't been updated for a while, marking as stale, please respond within the next 7 days to remove this label

@github-actions github-actions bot added the stale label Jan 12, 2024
@NissesSenap
Copy link
Collaborator

by bot, I need to review a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants