Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Regression of Bug 381 #850

Closed
andrewm-aero opened this issue Nov 18, 2022 · 1 comment · Fixed by #852
Closed

[Bug] Regression of Bug 381 #850

andrewm-aero opened this issue Nov 18, 2022 · 1 comment · Fixed by #852
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@andrewm-aero
Copy link

Describe the bug
Default rolling deployment strategy uses maxSurge and maxUnavailable of 25, not 25%, leading to downtime with any fewer than 26 replicas. This appears to be a regression of #381.

Version
docker.io/bitnami/grafana-operator:4.7.1-debian-11-r0

To Reproduce
Steps to reproduce the behavior:

  1. Deploy a Grafana resource with 25 or fewer replicas
  2. Wait for deployment to become healthy
  3. Modify the Grafana resource in a way that triggers an update to the pods
  4. Note how all pods are terminated immediately, resulting in downtime

Expected behavior
At least one pod to remain alive at all times.

Suspect component/Location where the bug might be occurring
Here

Screenshots
N/A

Runtime (please complete the following information):

N/A (but can be provided if needed)

Additional context
N/A

@andrewm-aero andrewm-aero added bug Something isn't working needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 18, 2022
@pb82 pb82 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 22, 2022
@pb82
Copy link
Collaborator

pb82 commented Nov 22, 2022

It looks like this has either never been fixed on master or was fixed and then changed back: https://github.com/grafana-operator/grafana-operator/blob/master/controllers/model/grafanaDeployment.go#L152

We're still setting 25 (as a number) instead of 25%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants