Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to disable ingress/route #906

Closed
weisdd opened this issue Dec 6, 2022 · 5 comments
Closed

Make it possible to disable ingress/route #906

weisdd opened this issue Dec 6, 2022 · 5 comments
Labels
help wanted Extra attention is needed triage/accepted Indicates an issue or PR is ready to be actively worked on. v5 A v5 specifc issue/feature
Milestone

Comments

@weisdd
Copy link
Collaborator

weisdd commented Dec 6, 2022

If you deploy a grafana with an Ingress set in the spec and then remove Ingress from the spec, Ingress object remains in the cluster.

A dangling ingress is not necessarily a big issue, because it's very unlikely for someone to specify ingress and then delete it. Though, if it's something that doesn't require much effort to fix, it'd be nice to do so.

@NissesSenap NissesSenap added the help wanted Extra attention is needed label Dec 19, 2022
@NissesSenap NissesSenap changed the title Ingress does not get deleted after it's removed from grafana spec Make it possible to disable ingress/route Mar 4, 2023
@NissesSenap
Copy link
Collaborator

How do we want to handle the creation of ingress/route? One solution would be to just say that if ingress/route is empty don't create a ingress or route, which seems like the easiest way.
But the bad thing here is that the OCP users that is currently used to have a route auto created for them won't get that fuctionallity.

Personally I think it's better that we have a consistent way of working and I think route and ingress should work the same way. So my suggestion is to have ingress/route disabled by default.

Another option is of course to keep the current way of working but we add some kind of ingress_enabled resource but it's kind of ugly and you could still have ingress config defined and have ingress_enabled: false and it would still be disabled which is a rather strange thing from a user point of view.

This would be good to fix before rc0.

@NissesSenap NissesSenap transferred this issue from grafana-operator/grafana-operator-experimental Mar 8, 2023
@NissesSenap NissesSenap added triage/accepted Indicates an issue or PR is ready to be actively worked on. v5 A v5 specifc issue/feature labels Mar 8, 2023
@NissesSenap NissesSenap added this to the Version 5.0 milestone Mar 8, 2023
@NissesSenap
Copy link
Collaborator

@tamcore Is this something that you are still open to look in to?
We are unable to keep up with the discussion in the other repo since it have been archived.

@weisdd
Copy link
Collaborator Author

weisdd commented Mar 18, 2023

@NissesSenap Shall we unarchive the experimental repo for a moment, transfer all outstanding issues to this repo, and then archive the experimental one again?

@NissesSenap
Copy link
Collaborator

It's the same issue, we had some discussions in there. I think we should be okay to keep this one instead.

@pb82
Copy link
Collaborator

pb82 commented May 2, 2023

fixed in #1028

@pb82 pb82 closed this as completed May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed triage/accepted Indicates an issue or PR is ready to be actively worked on. v5 A v5 specifc issue/feature
Projects
None yet
Development

No branches or pull requests

3 participants