-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to disable ingress/route #906
Comments
How do we want to handle the creation of ingress/route? One solution would be to just say that if ingress/route is empty don't create a ingress or route, which seems like the easiest way. Personally I think it's better that we have a consistent way of working and I think route and ingress should work the same way. So my suggestion is to have ingress/route disabled by default. Another option is of course to keep the current way of working but we add some kind of This would be good to fix before rc0. |
@tamcore Is this something that you are still open to look in to? |
@NissesSenap Shall we unarchive the experimental repo for a moment, transfer all outstanding issues to this repo, and then archive the experimental one again? |
It's the same issue, we had some discussions in there. I think we should be okay to keep this one instead. |
fixed in #1028 |
If you deploy a grafana with an Ingress set in the spec and then remove Ingress from the spec,
Ingress
object remains in the cluster.A dangling ingress is not necessarily a big issue, because it's very unlikely for someone to specify ingress and then delete it. Though, if it's something that doesn't require much effort to fix, it'd be nice to do so.
The text was updated successfully, but these errors were encountered: