Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Allow configuration of build matrix for the buildAll mage target #692

Closed
marefr opened this issue May 24, 2023 · 0 comments
Closed
Labels
enhancement New feature or request stale Issue or PR without activity type/build

Comments

@marefr
Copy link
Member

marefr commented May 24, 2023

What would you like to be added:
Disable certain architecture/platform in the buildAll mage target.

Why is this needed:
In case a plugin can't be built on certain platform it would be helpful to be able to disable a certain architecture/platform without having to define your own custom build target for your plugin.

Example: The grafana-flightsql-datasource can't be built for Linux ARM since Arrow dependency isn't supported there so they've created there own build target, see https://github.com/influxdata/grafana-flightsql-datasource/blob/7372d9f646691ccd44f31347f53170c7c93876b4/Magefile.go#L12-L18. When the buildAll mage target was changed to also include the dependency of GenerateManifestFile the grafana-flightsql-datasource didn't get this update when upgrading the grafana-plugin-sdk-go. Same problem could arise if we introduce new architecture/platform to the build matrix.

@marefr marefr added enhancement New feature or request type/build labels May 24, 2023
@github-actions github-actions bot added the stale Issue or PR without activity label Feb 29, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale Issue or PR without activity type/build
Projects
Archived in project
Development

No branches or pull requests

1 participant