Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert comments from HAR page entries into the JS when converting from HAR #126

Closed
robingustafsson opened this issue Oct 17, 2018 · 2 comments
Closed

Insert comments from HAR page entries into the JS when converting from HAR #126

robingustafsson opened this issue Oct 17, 2018 · 2 comments

Comments

@robingustafsson
Copy link
Member

If there's a comment attached to a page entry [1] include it as a comment in the generated JS script.

[1] - http://www.softwareishard.com/blog/har-12-spec/#pages
@codebien codebien transferred this issue from grafana/k6 Oct 3, 2023
@codebien
Copy link

codebien commented Oct 3, 2023

Moved here from the k6 repository, @e-fisher (as the last contributor) do you know if it is still a missing feature and if it is still relevant? If it has been implemented or it isn't relevant anymore then we should close it.

@e-fisher
Copy link
Contributor

e-fisher commented Oct 4, 2023

@codebien Tested and it's already implemented, thanks for bringing this to attention!

@e-fisher e-fisher closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@robingustafsson @codebien @e-fisher