Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tempo]: Enable Network Policy capability #2890

Open
hkailantzis opened this issue Jan 9, 2024 · 2 comments · May be fixed by #2922
Open

[Tempo]: Enable Network Policy capability #2890

hkailantzis opened this issue Jan 9, 2024 · 2 comments · May be fixed by #2922

Comments

@hkailantzis
Copy link

hkailantzis commented Jan 9, 2024

Is hard requirement for us to be able to define Network Policy for Tempo to be able to accept incoming traffic from Grafana or other components like opentelemetry-collector.
I can deploy manually for now the NP that I need, but would be great to have this option via the values.yaml. This applies to both single binary and distributed.

For Example: https://github.com/grafana/helm-charts/blob/main/charts/grafana/templates/networkpolicy.yaml

@Sheikh-Abubaker
Copy link
Contributor

Sheikh-Abubaker commented Jan 10, 2024

@hkailantzis I would like to work on this issue, I went through the example provided above, but I've just started contributing to Open Source and I'm unable to understand how to enable Network Policy capability for Tempo, are there any resources where I can look into to learn, understand and contribute to this one ? looking forward to learn!!

@hkailantzis
Copy link
Author

hkailantzis commented Jan 11, 2024

hi @Sheikh-Abubaker, no worries. Is not necessarily Tempo specific, is just Kubernetes related in the end:
Please find the corresponding values.yaml, for the example above, as they supplement each other: https://github.com/grafana/helm-charts/blob/main/charts/grafana/values.yaml#L1224C1-L1224C14
also official docu on Kubernetes Network policies:
https://kubernetes.io/docs/concepts/services-networking/network-policies/
The idea in general is that sometimes (like in my case), depending on K8s Cluster configurations, Network policies have to be configured for components (pods in the end), to allow outgoing or incoming traffic. So, imho, basically, any helm chart should have this option, so that users can configure those via the Chart and not deploying NP's manually...
Hope it helps!

@Sheikh-Abubaker Sheikh-Abubaker linked a pull request Jan 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants