Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling for near duplicate influx metrics #77

Open
alexgreenbank opened this issue Feb 23, 2023 · 0 comments
Open

Better handling for near duplicate influx metrics #77

alexgreenbank opened this issue Feb 23, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@alexgreenbank
Copy link
Contributor

This influx blog post on duplicate metrics has one suggestion of incrementing the timestamp by 1ns to ensure uniqueness.

Given that timestamps in Prometheus/Mimir have 1ms precision it is very unlikely (1 in 1,000,000) that an increase of 1ns will lead to a unique timestamp when it is translated/truncated to ms.

The proxy should check for timestamps that Influx would consider unique and do its best to ensure uniqueness in Mimir in a similar way (by incrementing timestamps by 1ms). Note this should only really be applied to near-duplicates it finds in an individual batch, not actual duplicates. Also inter-batch checks are beyond the scope of this initial work.

@alexgreenbank alexgreenbank added the enhancement New feature or request label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant