Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property aggregate query causes panic if the call to BatchGetAssetPropertyAggregatesPagesWithContext needs to be paged #182

Closed
kevinwcyu opened this issue May 4, 2023 · 2 comments

Comments

@kevinwcyu
Copy link
Contributor

What happened:

Run a property aggregate query with resolution set to auto and increase the time range until it causes the call to BatchGetAssetPropertyAggregatesPageAggregation needs to be paged.

This causes a panic because there is a mismatch of expectations when building the frames because we assume the success entries is flat with each item representing a single asset

Resolution: aws.StringValue(a.Request.Entries[i].Resolution),
Aggregates: aws.StringValueSlice(a.Request.Entries[i].AggregateTypes),

See original comment on this issue here #179 (comment)

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Screenshots

Anything else we need to know?:

Environment:

  • Grafana version:
  • Plugin version:
  • OS Grafana is installed on:
  • User OS & Browser:
  • Others:
@sarahzinger
Copy link
Member

Moving this to Next since I see a user is running into this issue

@kevinwcyu
Copy link
Contributor Author

kevinwcyu commented Jun 7, 2023

this should be fixed by #194 as well. will move this back to waiting for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants