Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests #189

Closed
10 tasks
kevinwcyu opened this issue May 16, 2023 · 2 comments
Closed
10 tasks

Refactor tests #189

kevinwcyu opened this issue May 16, 2023 · 2 comments
Labels
datasource/Sitewise type/bug Something isn't working

Comments

@kevinwcyu
Copy link
Contributor

kevinwcyu commented May 16, 2023

Work from this comment #179 (comment)

Sample PR: #190

Test files

  • pkg/resource/caching_resource_provider_test.go
  • pkg/server/test/describe_asset_model_test.go
  • pkg/server/test/describe_asset_test.go
  • pkg/server/test/list_asset_models_test.go
  • pkg/server/test/list_assets_test.go
  • pkg/server/test/list_associated_assets_test.go
  • pkg/server/test/property_value_history_test.go
  • pkg/server/test/property_values_for_time_range_test.go

Once test files are refactored, the following helpers, test data can be removed as they won't be used anymore

  • pkg/sitewise/api/test_data_test.go
  • pkg/testdata

Tasks

No tasks being tracked yet.
@fridgepoet
Copy link
Member

If it's clear to you which tests remain to be refactored, would you add a checklist or something?

@katebrenner
Copy link
Contributor

closing as not planned

@katebrenner katebrenner closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasource/Sitewise type/bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants