Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make signature tests 🍏 #10

Closed
oleiade opened this issue Aug 31, 2022 · 1 comment
Closed

make signature tests 🍏 #10

oleiade opened this issue Aug 31, 2022 · 1 comment
Assignees
@oleiade
Labels
bug Something isn't working

Comments

@oleiade
Copy link
Member

oleiade commented Aug 31, 2022

In the process of changing the way the lib is bundled up, and moving to typescript we broke the signature tests. They are currently failing at importing signature.js from src, because it... doesn't exist anymore.

We should instead import the signature.js from the build, and make sure that npm test would run the webpack command before actually running the test.
@oleiade oleiade self-assigned this Aug 31, 2022
@oleiade oleiade added the bug Something isn't working label Aug 31, 2022
@oleiade oleiade added this to the 0.5.0 milestone Aug 31, 2022
@oleiade oleiade mentioned this issue Aug 31, 2022
Open
@oleiade
Copy link
Member Author

oleiade commented Dec 8, 2022

Done in v0.7.0 ✅

@oleiade oleiade closed this as completed Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleiade oleiade

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oleiade