Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for priorityclasses and node tolerations & affinities #106

Open
mhaddon opened this issue May 6, 2022 · 3 comments
Open

Add support for priorityclasses and node tolerations & affinities #106

mhaddon opened this issue May 6, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@mhaddon
Copy link

mhaddon commented May 6, 2022

It would be nice to select a priorityclass so i can define prevent the pods from being deleted by another higher priority pod.
Node tolerations & affinities would also mean i can provision the pods on special nodes meant to run the load tests.

@yorugac
Copy link
Collaborator

yorugac commented May 10, 2022

@mhaddon Thank you for opening the issue 🙂 k6-operator does have support for affinity and nodeSelector as options though not for priorities. Out of curiosity, in your use case, can you rely on globalDefault option to avoid deletion of the pods?

At the moment, this seems to be relatively straight-forward to implement by passing priorityClassName to operator's pods. Open question would be whether the same field is sufficient for all operator's pods, runner and starter / initializer.

@yorugac yorugac added enhancement New feature or request good first issue Good for newcomers labels May 10, 2022
@mhaddon
Copy link
Author

mhaddon commented May 17, 2022

My globalDefault is normally on a lower priority setting which allows the pod to be evicted if something more important is running. The issue is that if k6 is load testing another application in kubernetes, that tool might scale up, and if it has a higher-priority, kubernetes will evict k6 to make it fit.

it would be nice to give k6 a priority that means it can never be evicted.

The issue is that it seems that if a k6 pod is re-created mid-test, it kinda borks the test.

@lucasoares
Copy link

I'd like the option to configure tolerations, nodeSelector etc using the same spec as I would normally use in the pod manifest.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants