Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ImagePullPolicy option on the runner and starter specs #152

Closed
jfroment opened this issue Sep 23, 2022 · 3 comments · Fixed by #154
Closed

Add ImagePullPolicy option on the runner and starter specs #152

jfroment opened this issue Sep 23, 2022 · 3 comments · Fixed by #154
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jfroment
Copy link

Feature Description

Would it be possible to add the field "imagePullPolicy" on the K6 CRD spec?
In our environment, we use custom images for both the runner images and the starter, these images containers extensions, internal tools, and certificates authorities to be able to communicate with the service we test.
But in order to ensure we always pull the latest image for a given tag, being able to set the imagePullPolicy to "always" would be a great plus.

Suggested Solution (optional)

No response

Already existing or connected issues / PRs (optional)

No response

@jfroment jfroment added the enhancement New feature or request label Sep 23, 2022
@yorugac
Copy link
Collaborator

yorugac commented Sep 23, 2022

Hi @jfroment, please see #145 - I believe it's the same issue.

@jfroment
Copy link
Author

jfroment commented Sep 23, 2022

Hi @yorugac , thanks for the quick answer!

If I'm not mistaken, the PR #145 is about ImagePullSecret while what I'm asking if for ImagePullPolicy, which is a different option. See the official documentation for more details. Basically it is a string with 3 possible options. The operator, by not specifying anything, sets it to "IfNotPresent" by default.

@yorugac
Copy link
Collaborator

yorugac commented Sep 26, 2022

@jfroment yes, you're right of course: I shouldn't have responded in a hurry 😅 Thank you for opening the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants