Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics aggregation review #192

Closed
yorugac opened this issue Feb 7, 2023 · 2 comments
Closed

Metrics aggregation review #192

yorugac opened this issue Feb 7, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request k6 Related to k6 itself PLZ

Comments

@yorugac
Copy link
Collaborator

yorugac commented Feb 7, 2023

k6 have been using partial metrics aggregation for k6 Cloud processing, best explained here:
https://github.com/grafana/k6/blob/b750e206859a495b8a1fe12aa016dc8ed0e1c9db/cloudapi/config.go#L40-L96

The k6-operator cloud output run does not take this into account at the moment. Find out:

  • did the new time series in k6 impact this partial aggregation?
  • what is the most performant way to use cloud output in k6 at the moment?
  • what needs to be changed in k6-operator invocation of k6 to take advantage of performant aggregation?

Implement changes as needs be.

@yorugac yorugac added enhancement New feature or request k6 Related to k6 itself labels Feb 7, 2023
@yorugac yorugac added the PLZ label Apr 27, 2023
@yorugac
Copy link
Collaborator Author

yorugac commented May 3, 2023

Metrics aggregation can be turned on k6's side with these env vars:

  K6_CLOUD_AGGREGATION_MIN_SAMPLES
  K6_CLOUD_AGGREGATION_PERIOD
  K6_CLOUD_AGGREGATION_WAIT_PERIOD
  K6_CLOUD_METRIC_PUSH_INTERVAL
  K6_CLOUD_MAX_METRIC_SAMPLES_PER_PACKAGE
  K6_CLOUD_MAX_METRIC_PUSH_CONCURRENCY

But also watch out for the progress in grafana/k6#2954 and grafana/k6#1700: once these are resolved, aggregation may be turned on by default, without the need for any env vars tinkering.

cc @codebien

@yorugac
Copy link
Collaborator Author

yorugac commented Jun 8, 2023

This is considered resolved with PR #229

@yorugac yorugac closed this as completed Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request k6 Related to k6 itself PLZ
Projects
None yet
Development

No branches or pull requests

1 participant