Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace text summary generation with JS code #1806

Closed
na-- opened this issue Jan 18, 2021 · 1 comment · Fixed by #1975
Closed

Replace text summary generation with JS code #1806

na-- opened this issue Jan 18, 2021 · 1 comment · Fixed by #1975
Milestone

Comments

@na--
Copy link
Member

na-- commented Jan 18, 2021

After #1788 and #1768, there's no need to generate the end-of-test text summary with Go code anymore. Indeed, the JSON summary is now generated by a JS function. However, because the last-minute replacement of the battle-tested Go summary generation with an untested JavaScript one is risky, we decided to postpone it to k6 v0.31.0.

For now the replacement code lives in https://gist.github.com/na--/eaf6540fae765499cbfddce1a052583f, and we'll deploy it to https://jslib.k6.io with the v0.30.0 release, so it can be used in handleSummary(). But at some point in the v0.31.0 cycle, we should bundle it in k6 and drop the old Go code. Ideally, with go.rice (or other Go bundler), so future bugfixes can be easily copied from the jslib version to it, or vice versa.

#1805 is a prerequisite for this issue. We can do it without it, but it would be a bit of a hack.

@na-- na-- added this to the v0.31.0 milestone Jan 18, 2021
@na--
Copy link
Member Author

na-- commented Jan 21, 2021

Alpha version of the JS-based summary helpers is live at https://jslib.k6.io/k6-summary/0.0.1/index.js (GitHub link is https://github.com/loadimpact/jslib.k6.io/tree/master/lib/k6-summary), though as I said in grafana/jslib.k6.io#20, it could definitely use some improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant