Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for schemeless urls #1862

Closed
mstoykov opened this issue Feb 17, 2021 · 3 comments
Closed

Drop support for schemeless urls #1862

mstoykov opened this issue Feb 17, 2021 · 3 comments
Labels
breaking change for PRs that need to be mentioned in the breaking changes section of the release notes feature

Comments

@mstoykov
Copy link
Collaborator

Since #1059 it has been allowed to import URLs with a scheme or more specifically with https(file is also supported for local files).

Previous to this, it was specifically required that there is no scheme and an https:// was added to the front and tried. For backward compatibility, this was left and a message was added that this is deprecated and instead https:// should be prepended.

IMO it is time for this to be dropped, both for simplifying the code and the error message (which was revised in #1439), but also to make it more distinguished between remote URLs and short URLs for github and cdnjs which still won't need https:// as they are basically not ... correct URLs, in the sense that they don't actually point to what is downloaded when k6 "resolves" them.

@mstoykov mstoykov added feature breaking change for PRs that need to be mentioned in the breaking changes section of the release notes labels Feb 17, 2021
@na--
Copy link
Member

na-- commented Feb 17, 2021

To be clear, we are not dropping the support for "magic" URLs (e.g. k6 run github.com/loadimpact/k6/samples/http_get.js), right? Given how we've used them in a ton of official docs examples over the years, I think we should just heavily discourage them and remove them from the docs for now... 😞

@mstoykov
Copy link
Collaborator Author

Yes,

make it more distinguished between remote URLs

was supposed to confirm that we are leaving them and now they will be less likely to be confused with "real" URLs

@mstoykov
Copy link
Collaborator Author

mstoykov commented Feb 2, 2024

Actually this was duplicated and then fixed in #3287 and #3451

@mstoykov mstoykov closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change for PRs that need to be mentioned in the breaking changes section of the release notes feature
Projects
None yet
Development

No branches or pull requests

2 participants