Issue with HEAD requests in 0.36.0?

[gygitlab]

Brief summary

After upgrading to 0.36.0 we noticed that in one of our tests it started failing with no successful requests. Uniquely this was the only test that was sending HEAD requests (http.head).

Digging further we identified our nginx server was rejecting all requests vaguely with 400 errors. After switching back to 0.35.0 the issue was no longer happening suggesting this is an issue on the k6 side.

k6 version

0.36.0

OS

Ubuntu 18.04, Mac OS 12.2.1

Docker version and image (if applicable)

No response

Steps to reproduce the problem

• Create a test sending HEAD requests, possibly against a standard nginx server
• Notice that they fail with 400 errors

Expected behaviour

HEAD requests are successful

Actual behaviour

HEAD requests are being rejected with 400 errors

[mstoykov]

Hi @grantyoung I think this as in v0.36.0 we did refactor this code and it seems that we made http.head take body as second argument as all other helpers except http.get 🤔

Can you confirm that adding a null body fixes this for you?

[gygitlab]

Hi @grantyoung I think this as in v0.36.0 we did refactor this code and it seems that we made http.head take body as second argument as all other helpers except http.get 🤔

Can you confirm that adding a null body fixes this for you?

It did indeed. It looks like you're going to revert though?

[na--]

Sorry @grantyoung, this seems to be a bug I introduced with #2226 that the tests didn't catch as a regression 😞 We plan to release v0.37.0 in a couple of weeks and we'll fix (#2402) it in there.

[gygitlab]

No problem at all @na--, thanks for the update.