Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ReadableStream (WIP) implementation pass WPT test suite #3659

Closed
10 of 12 tasks
Tracked by #2978
oleiade opened this issue Mar 21, 2024 · 2 comments · Fixed by #3696
Closed
10 of 12 tasks
Tracked by #2978

Make ReadableStream (WIP) implementation pass WPT test suite #3659

oleiade opened this issue Mar 21, 2024 · 2 comments · Fixed by #3696
Assignees

Comments

@oleiade
Copy link
Member

oleiade commented Mar 21, 2024

As we have a starting ReadableStream implementation, we aim to pass the relevant Web Platform Test suite's relevant tests.

Tasks

@joanlopez
Copy link
Contributor

joanlopez commented Apr 17, 2024

Status update (17/04)

  • General: 25 out of 38 pass
  • Patched global: Should we discard it?
  • Reentrant strategies: 3 fail => 1 (tee), 1 (pipeTo), 1 (flaky)
  • Tee: Should we discard it?

All the other test suites (bad strategies, bad underlying sources, cancel, ..., templated) work as expected! 🎉

Other stuff pending: revisit ReadableByteStreams?

Edit (17/04 EOD):
General: 32 out of 38 pass

@oleiade
Copy link
Member Author

oleiade commented Apr 18, 2024

In the context of this specific issue, we agreed to dismiss the patched-global test suite as we judge it irrelevant to our use case, and we decide to explicitly not implement and test the tee feature of streams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants