Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Improve connectivity errors handling #8

Closed
jifwin opened this issue Mar 24, 2016 · 0 comments
Closed

Improve connectivity errors handling #8

jifwin opened this issue Mar 24, 2016 · 0 comments

Comments

@jifwin
Copy link
Contributor

jifwin commented Mar 24, 2016

Hi
I've noticed that KairosDB plugin does not handle connectivity errors appropriately. For example: when datasource is down or there is an SSL handshake error Grafana throws errors like: "Cannot read property errors of undefined", "a.data is undefined" etc. As far as I understand Grafana expects response json to be in Kairos format. But when Kairos is unreachable, then response format is definitely not in such format (usually it's simply null).

Javascript type errors are not really appropriate in such case. Error messages should be more meaningful, to give user a sign, that there's a network problem and not with his query. Since it's not easy to distinguish what type of network error occured, my initial proposal is to set a general network error message ("Connectivity error" or something similar).

@jifwin jifwin closed this as completed Mar 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant