Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karpenter support #3

Closed
FalconerTC opened this issue Jan 17, 2023 · 7 comments
Closed

Karpenter support #3

FalconerTC opened this issue Jan 17, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@FalconerTC
Copy link

Maybe this is out of scope for this, but support for Karpenter managed node pools would be a nice feature I think

@inkel
Copy link
Collaborator

inkel commented Jan 30, 2023

Hi! Thanks for creating this issue. I honestly never heard of Karpenter, I assume you're talking about this project, correct? I'm reading the docs and I couldn't find a reference to node pools there, only node templates which seem to be something similar, but I'm failing to see if the nodes get created with any specific label that could help with this. I'll continue to investigate, though, but if you know the answer I'm more than happy to try and add it, or even review a PR 😉

@inkel inkel added the enhancement New feature or request label Jan 30, 2023
@inkel
Copy link
Collaborator

inkel commented Apr 11, 2023

Hi @FalconerTC! I just wanted to let you know that we're talking with @logyball about this request, as we're currently investigating Karpenter.

@logyball
Copy link
Contributor

Closed by #7

@inkel
Copy link
Collaborator

inkel commented Nov 6, 2023

Re-opening now that Karpenter has introduced nodepools. This will probably need some refactoring of #7 too.

@inkel inkel reopened this Nov 6, 2023
@logyball
Copy link
Contributor

logyball commented Nov 6, 2023

Looks like the only real upgrade will be changing the label from karpenter.sh/provisioner-name to karpenter.sh/nodepool, but we may want to consider if we'll support both the v1alpha5 spec of the Karpenter API, or go with just a clean break and do the v1beta1 API

@inkel
Copy link
Collaborator

inkel commented May 29, 2024

@logyball with the changes in #11, will this one consider close now?

@logyball
Copy link
Contributor

I'd say so! Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants