Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Difference Output #2

Open
joe-elliott opened this issue Nov 25, 2019 · 0 comments
Open

Improve Difference Output #2

joe-elliott opened this issue Nov 25, 2019 · 0 comments

Comments

@joe-elliott
Copy link
Member

Currently the logger just directly writes the output of https://github.com/go-test/deep. In most cases this is fine, but not great.

When changing the image for a deployment:

[Template.Spec.Containers.slice[0].Image: grafana/loki:master-61b5bc6 != grafana/loki:master-20bb95f]

In some cases it produces difficult to understand output. When changing memory limits:

[Template.Spec.Containers.slice[0].Resources.Limits.map[memory]: {{838860800 0} {} BinarySI} != {{209715200 0} {} BinarySI}]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joe-elliott