Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Levitate: move to ESM #393

Closed
leventebalogh opened this issue Jan 16, 2024 · 2 comments · Fixed by #423
Closed

Levitate: move to ESM #393

leventebalogh opened this issue Jan 16, 2024 · 2 comments · Fixed by #423
Assignees

Comments

@leventebalogh
Copy link
Collaborator

leventebalogh commented Jan 16, 2024

Related: grafana/plugin-tools#654

The problem

We have dependencies in the project (e.g. ora and execa) which we cannot update to because they are ESM only packages and current build tooling doesn't support them.

Possible solution

Build Levitate as an ESM package. (It shouldn't be a breaking change for node LTS).

@leventebalogh leventebalogh self-assigned this Jan 16, 2024
@tolzhabayev
Copy link
Collaborator

Can you add more as to what and why, do we expect someone who is using it to change anything (e.g.)? @leventebalogh

@leventebalogh
Copy link
Collaborator Author

Sure thing @tolzhabayev, good point!

I think in Grafana we are using Node v20, so it shouldn't be an issue. Regarding support I think it's fine to support the same node versions as @grafana/plugin-tools - however I will check where else levitate is used in our ecosystem to see if we don't break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants