Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to define grafana-agent resource requests in Loki chart values #10223

Closed
elcomtik opened this issue Aug 11, 2023 · 1 comment · Fixed by #11851
Closed

Allow to define grafana-agent resource requests in Loki chart values #10223

elcomtik opened this issue Aug 11, 2023 · 1 comment · Fixed by #11851
Labels
area/helm type/feature Something new we should do

Comments

@elcomtik
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, we cannot define resource requests and limits for the Grafana agent deployed by the Loki chart

Describe the solution you'd like
Grafana agent CRD defines this property https://github.com/grafana/agent/blob/main/production/operator/crds/monitoring.grafana.com_grafanaagents.yaml, so we should be able to add this to Grafana agent template

spec:
serviceAccountName: {{ include "loki.fullname" $ }}-grafana-agent
enableConfigReadAPI: {{ .enableConfigReadAPI }}
{{- include "grafana-agent.priorityClassName" $ | nindent 2 }}
logs:
instanceSelector:
matchLabels:
{{- include "loki.selectorLabels" $ | nindent 8 }}
{{- with $.Values.monitoring.serviceMonitor}}
{{- if .metricsInstance.remoteWrite}}
metrics:
instanceSelector:
matchLabels:
{{- include "loki.selectorLabels" $ | nindent 8 }}
{{- end }}

Describe alternatives you've considered
The alternative is to disable self-monitoring to prevent the deployment of the Grafana agent by this chart.

Additional context

@JStickler JStickler added type/feature Something new we should do area/helm labels Aug 16, 2023
@elcomtik
Copy link
Contributor Author

related to #10575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm type/feature Something new we should do
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants