Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logstash): clients logstash output structured metadata support #10899

Conversation

fostec82
Copy link
Contributor

What this PR does / why we need it:
This PR adds support for Loki Structured Metadata to the logstash output plugin.

Special notes for your reviewer:
Given that Structure Metadata is enabled as an experimental feature plugin changes were done in a way that is backward compatible for users not wanted structured metadata.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR

@fostec82 fostec82 requested a review from a team as a code owner October 13, 2023 18:04
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Oct 13, 2023
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] Thanks for updating the docs as part of your PR.

docs/sources/send-data/logstash/_index.md Outdated Show resolved Hide resolved
docs/sources/get-started/labels/structured-metadata.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for this addition!

@chaudum chaudum force-pushed the clients-logstash-output-structured-metadata-support branch from 6e94f55 to 6006405 Compare November 10, 2023 07:20
@chaudum chaudum merged commit 32f1ec2 into grafana:main Nov 10, 2023
8 checks passed
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
…rafana#10899)

**What this PR does / why we need it**:
This PR adds support for Loki Structured Metadata to the logstash output plugin.

**Special notes for your reviewer**:
Given that Structure Metadata is enabled as an experimental feature plugin changes were done in a way that is backward compatible for users not wanted structured metadata.

Co-authored-by: Jared King <kingjs@gmail.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
@aschepp
Copy link

aschepp commented May 2, 2024

Will this feature/version be pushed to RubyGems as well? Version 1.2.0 is not available there yet.

https://rubygems.org/gems/logstash-output-loki

@tiantangkuohai
Copy link

Will this feature/version be pushed to RubyGems as well? Version 1.2.0 is not available there yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants