Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: All lifecycler cfgs ref a valid IPv6 addr and port combination #11121

Merged
merged 3 commits into from Nov 6, 2023

Conversation

periklis
Copy link
Collaborator

@periklis periklis commented Nov 2, 2023

What this PR does / why we need it:
Ensure that all constructors of LifeCyclerConfig are using net.JoinHostPort for instance addr and port combinations. This enables IPv6 usage compatible across the code based. Currently only distributors provide IPv6 compatibility because they use Lifecycler (that pulls the addr/port in the NewLifeCycler) while everything else uses BasicLifeCycler delegate this to the user defining an addr/port combination in LifecyclerConfig.

Which issue(s) this PR fixes:
Fixes #10884

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@periklis periklis self-assigned this Nov 2, 2023
@periklis periklis requested a review from a team as a code owner November 2, 2023 14:16
@grafanabot
Copy link
Collaborator

Hello @periklis!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@periklis periklis added type/bug Somehing is not working as expected and removed missing-labels labels Nov 2, 2023
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@dannykopping dannykopping merged commit 6385b19 into grafana:main Nov 6, 2023
7 checks passed
grafanabot pushed a commit that referenced this pull request Nov 6, 2023
…11121)

**What this PR does / why we need it**:
Ensure that all constructors of LifeCyclerConfig are using
`net.JoinHostPort` for instance addr and port combinations. This enables
IPv6 usage compatible across the code based. Currently only distributors
provide IPv6 compatibility because they use `Lifecycler` (that pulls the
addr/port in the `NewLifeCycler`) while everything else uses
`BasicLifeCycler` delegate this to the user defining an addr/port
combination in `LifecyclerConfig`.

(cherry picked from commit 6385b19)
periklis added a commit that referenced this pull request Nov 6, 2023
…rt combination (#11144)

Backport 6385b19 from #11121

Co-authored-by: Periklis Tsirakidis <periklis@redhat.com>
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
…rafana#11121)

**What this PR does / why we need it**:
Ensure that all constructors of LifeCyclerConfig are using
`net.JoinHostPort` for instance addr and port combinations. This enables
IPv6 usage compatible across the code based. Currently only distributors
provide IPv6 compatibility because they use `Lifecycler` (that pulls the
addr/port in the `NewLifeCycler`) while everything else uses
`BasicLifeCycler` delegate this to the user defining an addr/port
combination in `LifecyclerConfig`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-2.9.x size/S type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loki query-scheduler is not working in ipv6 kubernetes clusters
3 participants