Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helm] Allow setting chunk memcached_client timeouts from helm chart #12413

Closed
anindyameister opened this issue Mar 31, 2024 · 2 comments
Closed
Labels
area/helm type/feature Something new we should do

Comments

@anindyameister
Copy link

anindyameister commented Mar 31, 2024

Is your feature request related to a problem? Please describe.
As seen here, the loki helm chart only reads the host and service for the chuck cache from helm values. Please enable timeout for the chunk memcache client in helm.

Describe the solution you'd like
Helm chart should add additional templating to allow configuring chunk cache timeouts.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@anindyameister anindyameister changed the title [Helm] Allow setting memcached timeouts from helm chart [Helm] Allow setting chunk memcached_client timeouts from helm chart Mar 31, 2024
@JStickler JStickler added type/feature Something new we should do area/helm labels Apr 1, 2024
@JStickler
Copy link
Contributor

I believe there is already a PR open for this. Does #10730 look like it would meet your needs?

@anindyameister
Copy link
Author

I believe there is already a PR open for this. Does #10730 look like it would meet your needs?

yes, that's exactly what I needed. I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm type/feature Something new we should do
Projects
None yet
Development

No branches or pull requests

2 participants