Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable log volume endpoint by default #12628

Merged
merged 1 commit into from
Apr 16, 2024
Merged

feat: Enable log volume endpoint by default #12628

merged 1 commit into from
Apr 16, 2024

Conversation

cyriltovena
Copy link
Contributor

What this PR does / why we need it:

This enables log volume endpoint by default which I think we should have done in 3.0 but was an oversight. This is used by the Explore Logs app and causing trouble at installation.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@cyriltovena cyriltovena requested a review from a team as a code owner April 16, 2024 08:32
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Apr 16, 2024
@cyriltovena cyriltovena merged commit 397aa56 into grafana:main Apr 16, 2024
13 checks passed
This was referenced Apr 22, 2024
Open
Open
This was referenced May 6, 2024
Open
Open
@loki-gh-app loki-gh-app bot mentioned this pull request May 20, 2024
Open
This was referenced May 27, 2024
Open
Open
This was referenced Jun 10, 2024
Open
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Jun 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelHollands MichelHollands MichelHollands approved these changes

Assignees
No one assigned
Labels
size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cyriltovena @MichelHollands