Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix the lokitool imports #12673

Merged
merged 1 commit into from
Apr 18, 2024
Merged

fix: Fix the lokitool imports #12673

merged 1 commit into from
Apr 18, 2024

Conversation

MichelHollands
Copy link
Contributor

What this PR does / why we need it:

The PR that introduced lokitool was not updated to use the new v3 Loki imports. This PR fixes that.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@MichelHollands
Use v3 loki
dd73425 
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
@MichelHollands MichelHollands requested a review from a team as a code owner April 18, 2024 14:21
chaudum
chaudum approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MichelHollands MichelHollands merged commit 6dce988 into main Apr 18, 2024
13 checks passed
@MichelHollands MichelHollands deleted the fix_lokitool_imports branch April 18, 2024 14:31
This was referenced Apr 22, 2024
Open
Open
This was referenced May 6, 2024
Open
Open
@loki-gh-app loki-gh-app bot mentioned this pull request May 20, 2024
Open
This was referenced May 27, 2024
Open
Open
This was referenced Jun 10, 2024
Open
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Jun 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaudum chaudum chaudum approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MichelHollands @chaudum