Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflows): don't run metric collector on forks #12687

Merged

Conversation

LukoJy3D
Copy link
Contributor

What this PR does / why we need it:

After a recent fork sync metrics-collector action started spamming with unsuccessful runs, but since its only used for github issue triage in the playground, there is no need for it to run on forks?

image


Run ./actions/metrics-collector
/home/runner/work/loki/loki/actions/node_modules/@actions/core/lib/core.js:106
        throw new Error(`Input required and not supplied: ${name}`);
        ^

Error: Input required and not supplied: token
    at Object.getInput (/home/runner/work/loki/loki/actions/node_modules/@actions/core/lib/core.js:106:15)
    at getRequiredInput (/home/runner/work/loki/loki/actions/common/utils.js:40:41)
    at new ActionBase (/home/runner/work/loki/loki/actions/common/Action.js:16:51)
    at new Action (/home/runner/work/loki/loki/actions/common/Action.js:103:9)
    at new MetricsCollector (/home/runner/work/loki/loki/actions/metrics-collector/index.js:8:9)
    at Object.<anonymous> (/home/runner/work/loki/loki/actions/metrics-collector/index.js:56:1)
    at Module._compile (node:internal/modules/cjs/loader:1198:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    at Module.load (node:internal/modules/cjs/loader:1076:32)
    at Function.Module._load (node:internal/modules/cjs/loader:911:12)

Since there were no changes in action itself I assume something changed with repo action settings

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@LukoJy3D LukoJy3D requested a review from a team as a code owner April 19, 2024 07:27
Copy link
Contributor

@cstyan cstyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep this seems like an action that should only run on our own upstream repo 👍

@cstyan cstyan merged commit 7253444 into grafana:main Apr 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants