Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing OTLP endpoint to nginx config #12709

Merged
merged 3 commits into from
Apr 22, 2024
Merged

fix: Add missing OTLP endpoint to nginx config #12709

merged 3 commits into from
Apr 22, 2024

Conversation

snrnats
Copy link
Contributor

@snrnats snrnats commented Apr 20, 2024 •
edited
Loading

What this PR does / why we need it:
This PR fix 404 response when pushing logs to OTLP endpoint, when Ingress is enabled.

Which issue(s) this PR fixes:
n/a

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@snrnats snrnats requested a review from a team as a code owner April 20, 2024 21:13
@CLAassistant
Copy link

CLAassistant commented Apr 20, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

slim-bean
slim-bean approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!!

@JStickler JStickler merged commit 8096748 into grafana:main Apr 22, 2024
16 checks passed
mattgialelis pushed a commit to mattgialelis/loki that referenced this pull request Apr 23, 2024
@snrnats @mattgialelis
fix: Add missing OTLP endpoint to nginx config (grafana#12709)
1a72a5e
@loki-gh-app loki-gh-app bot mentioned this pull request Apr 29, 2024
Open
This was referenced May 6, 2024
Open
Open
@loki-gh-app loki-gh-app bot mentioned this pull request May 20, 2024
Open
@vitoorgomes vitoorgomes mentioned this pull request May 20, 2024
Merged
2 tasks
@grafanabot grafanabot mentioned this pull request May 21, 2024
Merged
2 tasks
This was referenced May 27, 2024
Open
Open
This was referenced Jun 10, 2024
Open
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request Jun 24, 2024
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 1, 2024
Open
@grafanabot grafanabot mentioned this pull request Jul 2, 2024
Open
This was referenced Jul 3, 2024
Open
Closed
Open
@RodrigoCMoraes RodrigoCMoraes mentioned this pull request Jul 12, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 15, 2024
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slim-bean slim-bean slim-bean approved these changes

Assignees
No one assigned
Labels
area/helm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@snrnats @CLAassistant @slim-bean @JStickler