fix(packaging): Require online network in systemd unit file for Loki and Promtail #12741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Official documentation suggests to declare ``` After=network-online.target Wants=network-online.target ``` See https://systemd.io/NETWORK_ONLINE/#FAQ Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Official documentation suggests to declare ``` After=network-online.target Wants=network-online.target ``` See https://systemd.io/NETWORK_ONLINE/#FAQ Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
shantanualsi
pushed a commit
that referenced
this pull request
May 6, 2024
…and Promtail (#12741) From https://systemd.io/NETWORK_ONLINE/: **How do I make sure that my service starts after the network is really online?** That depends on your setup and the services you plan to run after it (see above). If you need to delay you service after network connectivity has been established, include ```systemd After=network-online.target Wants=network-online.target ``` in the `.service` file. This will delay boot until the network management software says the network is “up”. For details, see the next question. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
This was referenced May 6, 2024
This was referenced May 27, 2024
This was referenced Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
From https://systemd.io/NETWORK_ONLINE/:
How do I make sure that my service starts after the network is really online?
That depends on your setup and the services you plan to run after it (see above). If you need to delay you service after network connectivity has been established, include
in the
.servicefile.This will delay boot until the network management software says the network is “up”. For details, see the next question.
Which issue(s) this PR fixes:
Closes #12724
Checklist
CONTRIBUTING.mdguide (required)docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR