fix(blooms): Fix a regression introduced with #12774 #12776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
commented
Apr 24, 2024
pkg/bloomgateway/querier.go
Outdated
Comment on lines
127
to
148
| var seriesInBlocks int | ||
| var chunksInBlocks int | ||
| for _, b := range blocks { | ||
| seriesInBlocks += len(b.series) | ||
| for _, s := range b.series { | ||
| chunksInBlocks += len(s.Refs) | ||
| } | ||
| } | ||
| var chunksSkipped int | ||
| for _, s := range skipped { | ||
| chunksSkipped += len(s.Refs) | ||
| } | ||
| level.Debug(bq.logger).Log( | ||
| "msg", "debug skipped series", | ||
| "day", s.day.String(), | ||
| "series_total", len(s.series), | ||
| "series_in_blocks", seriesInBlocks, | ||
| "series_skipped", len(skipped), | ||
| "chunks_total", chunks, | ||
| "chunks_in_blocks", chunksInBlocks, | ||
| "chunks_skipped", chunksSkipped, | ||
| ) |
There was a problem hiding this comment.
Remove excessive logging
|
This PR must be merged before a backport PR will be created. |
1 similar comment
|
This PR must be merged before a backport PR will be created. |
owen-d
approved these changes
Apr 24, 2024
salvacorts
approved these changes
Apr 24, 2024
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
force-pushed
the
chaudum/fix-12774
branch
from
b6447eb
to
a544450
Compare
7 tasks
This was referenced May 6, 2024
This was referenced May 27, 2024
This was referenced Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes a regression introduced with #12774 where series where wrongly identified as "skipped" even though there were part of blocks.
Checklist
CONTRIBUTING.mdguide (required)docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR