Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing parentheses in meta monitoring dashboards #12802

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

MichelHollands
Copy link
Contributor

What this PR does / why we need it:

The meta-monitoring dashboards were missing parentheses causing them to not work. Note that these dashboard versions are only used in the meta monitoring chart.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
@MichelHollands MichelHollands requested a review from a team as a code owner April 26, 2024 10:47
@MichelHollands MichelHollands changed the title Add missing parentheses in dashboards fix: add missing parentheses in meta monitoring dashboards Apr 26, 2024
@MichelHollands MichelHollands merged commit 151d0a5 into main Apr 26, 2024
59 checks passed
@MichelHollands MichelHollands deleted the fix_operational_dashboard_missing_parenthesis branch April 26, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants