Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(detectedFields): add parser to response #12872

Merged
merged 5 commits into from
May 3, 2024
Merged

feat(detectedFields): add parser to response #12872

merged 5 commits into from
May 3, 2024

Conversation

svennergr
Copy link
Contributor

What this PR does / why we need it:

Adds the parser (json or logfmt for now) to the response of detected_fields.

@svennergr svennergr force-pushed the svennergr/detected-fields-type branch from 56671b8 to e1f9f30 Compare May 3, 2024 09:46
@pull-request-size pull-request-size bot added size/M and removed size/S labels May 3, 2024
@svennergr svennergr marked this pull request as ready for review May 3, 2024 11:41
@svennergr svennergr requested a review from a team as a code owner May 3, 2024 11:41
cyriltovena
cyriltovena approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 2b3ae48 into main May 3, 2024
59 checks passed
@cyriltovena cyriltovena deleted the svennergr/detected-fields-type branch May 3, 2024 11:47
@svennergr svennergr mentioned this pull request May 3, 2024
Draft
shantanualsi pushed a commit that referenced this pull request May 6, 2024
@svennergr @shantanualsi
feat(detectedFields): add parser to response (#12872)
1b32fc1
This was referenced May 6, 2024
Open
Open
@loki-gh-app loki-gh-app bot mentioned this pull request May 20, 2024
Open
This was referenced May 27, 2024
Open
Open
This was referenced Jun 10, 2024
Open
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Jun 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

@trevorwhitney trevorwhitney Awaiting requested review from trevorwhitney

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@svennergr @cyriltovena