Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fluent-plugin-grafana-loki: add option to disable server certificate verification #1986

Closed
jgehrcke opened this issue Apr 26, 2020 · 10 comments · Fixed by #2171
Closed

fluent-plugin-grafana-loki: add option to disable server certificate verification #1986

jgehrcke opened this issue Apr 26, 2020 · 10 comments · Fixed by #2171
Labels
component/agent help wanted We would love help on these issues. Please come help us! keepalive An issue or PR that will be kept alive and never marked as stale. type/enhancement Something existing could be improved

Comments

@jgehrcke
Copy link
Contributor

Unless I am missing something (entirely possible) the plugin has no configuration parameter to disable server certificate verification. This should be added for test setups and the like.

The parameter could for example be called tls_verify or tls_insecure.

Related:
https://docs.fluentd.org/configuration/transport-section#parameters
@stale
Copy link

stale bot commented May 26, 2020

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label May 26, 2020
@stale stale bot closed this as completed Jun 2, 2020
@jgehrcke
Copy link
Contributor Author

jgehrcke commented Jun 3, 2020

@cyriltovena @wardbekker @takanabe let's revive this, right?

@cyriltovena cyriltovena added keepalive An issue or PR that will be kept alive and never marked as stale. type/enhancement Something existing could be improved help wanted We would love help on these issues. Please come help us! component/agent labels Jun 3, 2020
@cyriltovena cyriltovena reopened this Jun 3, 2020
@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Jun 3, 2020
@takanabe
Copy link
Contributor

takanabe commented Jun 3, 2020

I don't think fluent-plugin-grafana-loki uses server/http_server plugin helpers. So, I think the options for disabling server certificate verification is not necessary.

@takanabe
Copy link
Contributor

takanabe commented Jun 3, 2020

ah... maybe, I misunderstood you 💦 https://github.com/grafana/loki/pull/2171/files is what are you expecting?

@cyriltovena
Copy link
Contributor

I think yes ! @jgehrcke Can you confirm ?

@takanabe takanabe mentioned this issue Jun 3, 2020
Merged
2 tasks
@jgehrcke
Copy link
Contributor Author

jgehrcke commented Jun 4, 2020

#2171 came off with a bit of a misunderstanding of this issue here but I'll happily provide guidance. We'll get there.

@jgehrcke
Copy link
Contributor Author

jgehrcke commented Jul 6, 2020 •
edited

@cyriltovena would you mind pushing the 1.2.13 release to https://rubygems.org/gems/fluent-plugin-grafana-loki?

CC @woodsaj @briangann

@cyriltovena
Copy link
Contributor

will do now.

@cyriltovena
Copy link
Contributor

Should be good now

@jgehrcke
Copy link
Contributor Author

jgehrcke commented Jul 7, 2020

Thank you @cyriltovena!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/agent help wanted We would love help on these issues. Please come help us! keepalive An issue or PR that will be kept alive and never marked as stale. type/enhancement Something existing could be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add server TLS certificate verification takanabe/loki
3 participants
@jgehrcke @cyriltovena @takanabe