-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback wanted: deprecate our Loki FluentBit plugin in favor of native FluentBit output. #4648
Comments
Hi Loki users, As part of the Fluent Bit team, we want to bring a first-class citizen experience with Loki and we would like to know what are the specific missing features in our built-in connector: Since the Golang connector will be deprecated, please let us know what is needed to prioritize on our side. thanks. |
@owen-d I swapped over from the native Fluentd implementation to the native Fluent Bit implementation as soon as Loki v2.4 was release and I've been very happy with both parts. @edsiper I think there are a few outstanding Loki issues on the Fluent Bit repo that need triaging against the latest versions? Off the top of my head the following areas need looking into, but I've not seen any of them since upgrading to the latest versions:
|
@edsiper We have out of order now available, so we should be able to change the implementation of fluentbit to send batches in parallel. |
I would very much like to see this plugin continue to be supported. We prefer having a golang output plugin available, as our team is significantly deeper in Go than C skills, and in addition to supporting the code, we intend to make a couple of small, local modifications. I understand (correct me if I'm mistaken @edsiper ) that there are a couple of areas in which the native plugin needs to be brought up to par (e.g. support for batch compression), and while those are definitely good things to have, their addition to the C plugin doesn't help our specific case. So I would ask the Loki team to put off deprecating the golang plugin for now, if possible. |
I personally agree with deprecation: there is a fair bit of confusion with mismatches in configuration across the two plugins and so people follow a blog post/etc. for the Grafana one but use the Fluent one and then get failures. There is also the duplication of effort required: implement a feature in one then in the other (maybe slightly differently) plus the fragmentation of features. Having a single official plugin is much preferable for support, documentation, development and testing. |
@owen-d what was the outcome of this? Just curious if the plan is to deprecate or not - and when if so? |
First used the fluent-bit native and the had to switch to Loki's one as we had failures to send to loki after a while (maybe after a disconnection / small network interruption) |
@edsiper Where is functionality of custom labels? In |
So, is it possible to implement it? |
@nokute78 can you implement the LabelMapPath feature please ? , ref: https://grafana.com/docs/loki/latest/clients/fluentbit/#labelmappath |
@edsiper I created a patch to support |
awesome! thanks @nokute78 ! |
|
Hello! It's been almost 2 years since the creation of this issue. AFAIK, this parameters are not supported by the builtin output:
And some others could be achieved using other non loki output specific FBit output parameters: e.g. #1
e.g. #2
buffering could be implemented using own FBit's storage parameters and limiting the size. Am I right? |
@aleonsan thanks for the good analysis - any chance you can raise an issue on the OSS repo to track the new features we may need? This is a Grafana repo so I cannot comment on their roadmap but from an OSS perspective I'd really like to make sure we have feature parity and a migration approach. We regularly get issues raised due to using the Grafana docs but the OSS image, plus the current Grafana image is now based on an unsupported 1.9 version of OSS - we're up to 2.1.7 as of today with a load of new features including OTEL compliance. |
Hello, CompressionAfter the migration we observed 6-8x higher traffic on loki-gateway than before. According to my investigation, it seems like https://github.com/grafana/loki/blob/v2.9.0/clients/pkg/promtail/client/client.go#L442-L453 413 Request Entity Too Large by loki-gateway
https://nginx.org/en/docs/http/ngx_http_core_module.html#client_max_body_size |
@ksauzz any feedback on the OSS side needs to be fed back to the OSS repo rather than this Grafana one otherwise it won't be seen. |
I started with native and had to switch to grafana-loki for this reason: The native Fluent-bit loki plugin does not support a custom URI , you can only set the Host and the Port, but you have no control over the URI (the path). With grafana-loki plugin, you can set a full Url. Now I'm struggling with grafana-loki plugin to configure tls, I don't see that it's possible in the documentation, if anyone has an idea please help |
@Turkish thanks for your feedback. I have submitted a PR to implement that feature in Fluent Bit: |
hey folks, just wanted to check what else is needed to complete the transition, last two missing pieces around compression and configurable URI has been addressed. Please report any missing thing here. |
It would be interesting to find a solution for how to push structured metadata to Loki using the fluent-bit Loki output. |
OSS Fluent Bit does include an additional optional metadata section in every record now, primarily to support some of the OTEL requirements I believe. This potentially could be used. |
Hey guys |
Hi Folks, regarding the initial requirements around batching, is this still highly necessary ? I would like to learn from urgency level of this |
Hello! A long time ago we wrote a plugin for ingesting logs in Loki from
fluentbit
. These days, there's a native output option for Loki available in fluentbit itself courtesy of @edsiper. I'm opening this issue to solicit feedback from Loki users currently using either of these in hopeful preparation for deprecating our plugin in favor of theirs.We hope the introduction of
out of order
support in Loki has helped make this feasible :)cc @cyriltovena
The text was updated successfully, but these errors were encountered: