Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compression improvement. #689

Closed
cyriltovena opened this issue Jun 20, 2019 · 4 comments
Closed

Compression improvement. #689

cyriltovena opened this issue Jun 20, 2019 · 4 comments
Labels
component/loki stale A stale issue or PR that will automatically be closed. type/feature Something new we should do

Comments

@cyriltovena
Copy link
Contributor

When looking at memory comsumption we can see that a big part of it is due to the compression.

1 - we should look into pooling CompressionWriter creation. (https://github.com/grafana/loki/blob/master/pkg/chunkenc/gzip.go#L149) Currently one is created for every chunk, gzip is known to be a huge memory eater see and golang/go#32371 golang/go#18625
2 - introduce benchmark with more compression options to have different tradeoff.

@gouthamve started the work here https://github.com/gouthamve/logish-explore/tree/master/chunkenc we should bring it to Loki.
@cyriltovena cyriltovena added component/loki type/feature Something new we should do labels Jun 20, 2019
@mizeng
Copy link
Contributor

mizeng commented Jun 21, 2019

I saw one doc about result on different compression.

@gregwebs
Copy link

gregwebs commented Jul 1, 2019

Can we have an option to turn off compression? Then it would be easy to see how much of the memory leak issue this is causing.

@stale
Copy link

stale bot commented Sep 3, 2019

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Sep 3, 2019
@stale stale bot closed this as completed Sep 10, 2019
@isavcic
Copy link

isavcic commented Jan 4, 2020

Why is zstandard "broken" in that doc? @mizeng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/loki stale A stale issue or PR that will automatically be closed. type/feature Something new we should do
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gregwebs @cyriltovena @isavcic @mizeng