Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

data race on chunk.Saved #155

Closed
Dieterbe opened this issue Feb 24, 2016 · 2 comments
Closed

data race on chunk.Saved #155

Dieterbe opened this issue Feb 24, 2016 · 2 comments

Comments

@Dieterbe
Copy link
Contributor

this property is concurrently ready by AggMetric and written to by cassandraStore without synchronisation. not sure how to most elegantly fix, our locking in AggMetric is on AggMetric level, we don't have locks on individual chunks. We could track a pointer to the AggMetric in the ChunkWriteRequest for cassandraStore to use

@woodsaj
Copy link
Member

woodsaj commented Feb 24, 2016

I think we need to add the mutex on the individual chunks. A chunk can exist outside of a aggMetric, eg if the chunk is added to the writeQueue and then bumped from the AggMetrics circular buffer.

@Dieterbe
Copy link
Contributor Author

fixed by #485

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants