Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

deletes don't affect stale metrics. They may resurface if max-stale gets increased #1982

Closed
Dieterbe opened this issue May 20, 2021 · 2 comments

Comments

@Dieterbe
Copy link
Contributor

Consider:
A metric that is stale and thus doesn't live in MT's memory index but still lives in the regular table if it haven't been archived yet).
A delete query won't catch it. Normally this is fine. the metric won't be in the memory index and thus it can't be queried for data. If new data comes in, it will become un-stale and resurface its data. But that's the same behavior as the normal delete case of non-stale metrics, which also resurface if new data comes in.

Where this gets interesting though:

  1. if you increase the max-stale time window, the metrics may resurface by themselves
  2. revive functionality, as proposed in Ability to "revive" archived series #1976 may also mistakenly reintroduce metrics that may needed to be deleted. (as delete queries can't reach into the archive table)
@Dieterbe Dieterbe added the bug label May 20, 2021
@Dieterbe Dieterbe changed the title deletes don't affect stale metrics. They may resurface when max-stale gets increased deletes don't affect stale metrics. They may resurface if max-stale gets increased May 20, 2021
@Dieterbe
Copy link
Contributor Author

Dieterbe commented Jun 4, 2021

I think this is an acceptable limitation.

@stale
Copy link

stale bot commented Sep 3, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 3, 2021
@stale stale bot closed this as completed Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant