Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

make tags strings instead of numbers #31

Closed
Dieterbe opened this issue Sep 29, 2015 · 2 comments
Closed

make tags strings instead of numbers #31

Dieterbe opened this issue Sep 29, 2015 · 2 comments

Comments

@Dieterbe
Copy link
Contributor

(*schema.MetricData)(0xc8201de300)({
 OrgId: (int) 1,
 Name: (string) (len=37) "litmus.localhost.dev1.dns.error_state",
 Metric: (string) (len=22) "litmus.dns.error_state",
 Interval: (int) 10,
 Value: (float64) 0,
 Unit: (string) (len=5) "state",
 Time: (int64) 1443523161,
 TargetType: (string) (len=5) "gauge",
 Tags: ([]string) (len=3 cap=3) {
  (string) (len=13) "endpoint_id:1",
  (string) (len=12) "monitor_id:4",
  (string) (len=14) "collector:dev1"
 }
})

just curious, why tags like endpoint_id:1 and not endpoint=localhost ? (the latter would facilicate some search (metrics2.0/graph-explorer style) scenarios where you can search for all metrics with endpoint=localhost etc, or autocomplete/auto-suggest: give me all values for endpoint=local*)

@woodsaj
Copy link
Member

woodsaj commented Sep 29, 2015

no real good reason. Mostly just a relic of previous incarnations.

Changing the code to replace or add additional tags is easy, but in order for users to lot lose access to all of the existing data in kairosdb/cassandra, we would need to perform a data migration. And given we have ~800Gb of data already that would not be a easy task.

@Dieterbe Dieterbe changed the title why do the tags contain id numbers? make tags strings instead of numbers Apr 7, 2016
@Dieterbe
Copy link
Contributor Author

this is not an MT issue. it is one of the action items on https://github.com/raintank/ops/issues/282

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants