Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor store-gateway index cache to remove duplication #3778

Open
56quarters opened this issue Dec 20, 2022 · 0 comments
Open

Refactor store-gateway index cache to remove duplication #3778

56quarters opened this issue Dec 20, 2022 · 0 comments

Comments

@56quarters
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The index cache in the store-gateway currently has an in-memory implementation and a memcached implementation. There's a lot of overlap between these two implementation. This complicates changes required for #3772 (though index cache won't be the first cached updated, it may be eventually updated to use memory pooling).

Describe the solution you'd like

The caching package in dskit has an abstraction so that differences between caching layers can be ignored, we should use it with respect to the index cache. Then we can implement an in-memory version of the Cache interface and remove other versions of the indexcache besides the one meant to work with the dskit Cache interface.

Describe alternatives you've considered

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant