Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove storage chunks clients #527

Closed
09jvilla opened this issue Nov 24, 2021 · 3 comments
Closed

Remove storage chunks clients #527

09jvilla opened this issue Nov 24, 2021 · 3 comments

Comments

@09jvilla
Copy link
Contributor

No description provided.

@09jvilla
Copy link
Contributor Author

09jvilla commented Jan 4, 2022

From @pstibrany

I believe 527 is about removing pkg/chunk/aws, pkg/chunk/gcp, pkg/chunk/cassandra, basically everything that implements ObjectClient and IndexClient interfaces.

It's not used outside of chunks code.

ideally entire pkg/chunk should be gone, but there may be bits that are still needed

see https://raintank-corp.slack.com/archives/C029912SXT8/p1641315878026300?thread_ts=1641311201.022900&cid=C029912SXT8

@simonswine
Copy link
Contributor

The majority of the packages underneath github.com/grafana/mimir/pkg/chunk should be removed as part of this work.

This make sense to touch after #525

As ticket #5 mentions, parts of the purger are still relevant in particular:

  • pkg/chunk/purger/tenant_deletion_api.go

@pracucci
Copy link
Collaborator

I addressed this in #755.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants