Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remover Purger Delete Series, List Delete Requests, Cancel Delete Request HTTP API Endpoints #555

Closed
09jvilla opened this issue Dec 1, 2021 · 4 comments · Fixed by #743
Assignees

Comments

@09jvilla
Copy link
Contributor

09jvilla commented Dec 1, 2021

The delete series, list delete requests, and cancel delete request part of the Mimir HTTP API can be removed since they only work for chunks storage.

Tenant delete request and Tenant delete status should be left as is since they work with blocks storage.

@09jvilla
Copy link
Contributor Author

09jvilla commented Dec 1, 2021

@pstibrany can any of the knobs from the purger config be removed as well now that we're removing chunks storage?

@pstibrany
Copy link
Member

I think we should instead work on implementing the APIs when running blocks storage. (There is a proposal in Cortex for this).

@pstibrany
Copy link
Member

pstibrany commented Dec 1, 2021

@pstibrany can any of the knobs from the purger config be removed as well now that we're removing chunks storage?

If we remove the current implementation, then all these knobs can be removed.

@09jvilla
Copy link
Contributor Author

09jvilla commented Dec 1, 2021

Fair, I agree with you that just implementing these APIs is better than deleting them. The ability to delete series seems like important baseline functionality for a tsdb.

I've seen the proposal before and that there is a PR, but it was hard for me to tell if it is still moving along since its been open for months.

I'll put this at the end of our list of issues for mimir cleanup and we can revisit then. If this PR is further along, we may be able to just pull in the code directly to mimir.

@Logiraptor Logiraptor self-assigned this Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants