Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the provisioning doc correct? #29

Closed
benjamin-bergia opened this issue May 27, 2021 · 5 comments · Fixed by #30
Closed

Is the provisioning doc correct? #29

benjamin-bergia opened this issue May 27, 2021 · 5 comments · Fixed by #30

Comments

@benjamin-bergia
Copy link
Contributor

Hi,

I am trying to replace my elasticsearch datasources with this plugin. The plugin is installed correctly and I didn't touch my provisioning files since the config and type seemsto be exactly the same than for ES. Unfortunately the query editor is still the same and it looks like it is not using the plugin.

Shouldn't the type in here be something different than:

datasources:
  - name: elasticsearch-v7-filebeat
    type: elasticsearch

?

@Elfo404
Copy link
Member

Elfo404 commented May 27, 2021

Hi @benjamin-bergia
good catch, the correct value is type: grafana-es-open-distro-datasource, we need to update the docs.

could you submit a PR?

thanks for reporting it!

@benjamin-bergia
Copy link
Contributor Author

benjamin-bergia commented May 28, 2021

Ok I will have a look. Quick question: is there other options that are different from the elasticsearch datasource and should be documented?

@Elfo404
Copy link
Member

Elfo404 commented May 28, 2021

In the provisioning configuration i think no, the id should be the only thing that changed

@benjamin-bergia
Copy link
Contributor Author

I think I have seen an option to enable/disable ppl somewhere but I can't remember where.

@Elfo404
Copy link
Member

Elfo404 commented May 28, 2021

true! should be jsonData.pplEnabled (boolean). also missing in docs but available in the DS settings:
Screenshot 2021-05-28 at 11 17 21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants