Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to view a particular trace from open search in a trace view #106

Closed
Tracked by #103
sarahzinger opened this issue Mar 6, 2023 · 4 comments
Closed
Tracked by #103

Comments

@sarahzinger
Copy link
Member

sarahzinger commented Mar 6, 2023

Depends on completion of #105 first

The goal here is to be able to type in a lucene query for a particular trace (something like this maybe, not sure on the groupby bits):
Screenshot 2023-03-07 at 8 16 06 AM

and then return back information about that trace that can be viewed in the Traces visualization, see example from X-ray plugin:

Screenshot 2023-03-06 at 5 07 16 PM

It's possible this work might be best split up into multiple tickets, and that there might be a few unforeseen additional things we'll need to do, but I suspect the work here will generally involve:

  • adding a "Trace" option to the query editor
  • setting it so that when a user selects the trace option and passes a trace id, it calls the /_msearch endpoint with the correct arguments so that we get all spans for a particular trace id, see https://docs.google.com/document/d/1l8HYKvCddF9jUdkAV0TkHU6fsWFs8T1s-gLWbaGLtog/edit
  • then figuring out how to format the data into a data frame so that the Traces visualization can parse this and show the right visualization (will likely want to look at X-Ray to see how this is done)
@sarahzinger
Copy link
Member Author

slightly blocked by #105 but I think it's actually fairly easy to set up an open search instance locally with traces, we're just stuck on putting it in the AWS OpenSearch Service atm

@sarahzinger
Copy link
Member Author

realizing this one might be a bit easier to start with: #107 so I'm going to start on this one. But I think anyone could still pick this up and start looking into how to map a trace to the traces visiualization

@sarahzinger
Copy link
Member Author

@idastambuk is a bit blocked on this since I'm still working on the query to get all traces, but she's going to try first rendering the traces visualization with mock data to see if we know what we need to query for.

@taleena
Copy link

taleena commented Aug 4, 2023

This was done in Apr and counted there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants