Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to auto-detect version to config editor #132

Closed
Tracked by #120
iwysiu opened this issue Apr 11, 2023 · 1 comment · Fixed by #153
Closed
Tracked by #120

Add button to auto-detect version to config editor #132

iwysiu opened this issue Apr 11, 2023 · 1 comment · Fixed by #153

Comments

@iwysiu
Copy link
Contributor

iwysiu commented Apr 11, 2023

Change the ConfigEditor to have a button to detect the version. Instead of having the version selected from a dropdown, we have a button to detect the version and set it. When the button is pushed, we can save the datasource, fetch the OpenSearch version, and re-save the datasource with that information. Note that the datasource needs to be saved first, so that the backend has the correct http address and credentials to send the request. We should still display the version in the editor
We should also change testDatasource to fail for ElasticSearch v7.10+ and v8.x and point the user toward the ElasticSearch datasource, and to default to a null version instead of OpenSearch 1.0.x, to make it clearer when it hasn't been set.

@iwysiu
Copy link
Contributor Author

iwysiu commented May 10, 2023

Video of the added feature:

Screen.Recording.2023-05-10.at.6.12.32.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant